upstream/MinecraftForge
1
0 Fork 0
mirror of https://github.com/MinecraftForge/MinecraftForge.git synced 2026-11-13 00:37:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix buffer leak in vanilla custom payload packet handling (#4512)

Browse Source
This commit is contained in:
Ben Staddon authored and LexManos committed 2017-11-12 10:38:10 -08:00
1 parent ad202e2e83
commit baaa6c6505
2 files changed
+16 -1
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

patches/minecraft/net/minecraft/client/network/NetHandlerPlayClient.java.patch
+8
View File
@@ -82,3 +82,11 @@
if (potion != null)
{
@@ -1856,6 +1867,7 @@
}
finally
{
+ if (false) // Forge: let packet handle releasing buffer
packetbuffer.release();
}
}
patches/minecraft/net/minecraft/network/play/server/SPacketCustomPayload.java.patch
+8 -1
View File
@@ -1,6 +1,6 @@
--- ../src-base/minecraft/net/minecraft/network/play/server/SPacketCustomPayload.java
+++ ../src-work/minecraft/net/minecraft/network/play/server/SPacketCustomPayload.java
@@ -46,7 +46,11 @@
@@ -46,12 +46,18 @@
public void func_148840_b(PacketBuffer p_148840_1_) throws IOException
{
p_148840_1_.func_180714_a(this.field_149172_a);
@@ -12,3 +12,10 @@
}
public void func_148833_a(INetHandlerPlayClient p_148833_1_)
{
p_148833_1_.func_147240_a(this);
+ // Forge: fix network buffer leaks (MC-121884)
+ if (this.field_149171_b != null) this.field_149171_b.release();
}
@SideOnly(Side.CLIENT)