upstream/CustomNPC-Plus
2
0 Fork 0
mirror of https://github.com/KAMKEEL/CustomNPC-Plus.git synced 2026-11-12 17:47:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed method calls of JS type constructors throwing errors, made it dynamic

Browse Source
This commit is contained in:
bigguy345 committed 2026-03-09 00:35:53 +02:00
1 parent dc3e25bcba
commit e3fc9e8e4a
2 files changed
+13 -7
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/main/java/noppes/npcs/client/gui/util/script/interpreter/hover/TokenHoverInfo.java
+3
View File
@@ -243,6 +243,9 @@ public class TokenHoverInfo {
if (callInfo.hasStaticAccessError()) {
errors.add(callInfo.getErrorMessage());
}
if (callInfo.getErrorType() == MethodCallInfo.ErrorType.UNRESOLVED_METHOD) {
errors.add(callInfo.getErrorMessage());
}
}
// Show field access errors
src/main/java/noppes/npcs/client/gui/util/script/interpreter/method/MethodCallInfo.java
+10 -7
View File
@@ -331,13 +331,16 @@ public class MethodCallInfo {
public void validate() {
if (isConstructor) {
if (resolvedMethod == null) {
// For constructors, check if the type has any constructors at all
if (receiverType != null && receiverType.hasConstructors()) {
setError(ErrorType.WRONG_ARG_COUNT,
"No constructor in '" + receiverType.getSimpleName() + "' matches " + arguments.size() + " argument(s)");
} else {
setError(ErrorType.UNRESOLVED_METHOD,
"Cannot resolve constructor for '" + methodName + "'");
// Don't report missing JS constructors as unresolved method error, since they may be created dynamically at runtime
boolean isJSType = receiverType != null && receiverType.isJSType();
if (!isJSType) {
if (receiverType != null && receiverType.hasConstructors()) {
setError(ErrorType.WRONG_ARG_COUNT,
"No constructor in '" + receiverType.getSimpleName() + "' matches " + arguments.size() + " argument(s)");
} else {
setError(ErrorType.UNRESOLVED_METHOD,
"Cannot resolve constructor for '" + methodName + "'");
}
}
} else if (receiverType != null) {
List<FieldInfo> cParams = resolvedMethod.getParameters();