From b2e0b8878a21c5218f4076e5802cdbf9cc67eb91 Mon Sep 17 00:00:00 2001 From: Luca <38906805+Luca-Guettinger@users.noreply.github.com> Date: Sat, 25 Apr 2026 12:21:46 +0200 Subject: [PATCH] Fix bookmark recipe item order being inconsistent (#921) --- .../nei/bookmark/BookmarkGrid.java | 22 ++++++++++++++----- 1 file changed, 16 insertions(+), 6 deletions(-) diff --git a/src/main/java/codechicken/nei/bookmark/BookmarkGrid.java b/src/main/java/codechicken/nei/bookmark/BookmarkGrid.java index e7dd989d..912d410b 100644 --- a/src/main/java/codechicken/nei/bookmark/BookmarkGrid.java +++ b/src/main/java/codechicken/nei/bookmark/BookmarkGrid.java @@ -898,25 +898,35 @@ public class BookmarkGrid extends ItemsGrid results = new ArrayList<>(); + final List ingredients = new ArrayList<>(); for (RecipeIngredient result : recipe.getResults()) { - results.add(result.getItemStack()); + ItemStack stack = result.getItemStack(); + if (!seenResults.contains(stack)) { + seenResults.add(stack); + results.add(stack); + } } for (RecipeIngredient ingr : recipe.getIngredients()) { - ingredients.add(ingr.getItemStack()); + ItemStack stack = ingr.getItemStack(); + if (!seenIngredients.contains(stack)) { + seenIngredients.add(stack); + ingredients.add(stack); + } } - for (ItemStack stack : results.values()) { + for (ItemStack stack : results) { this.addItem( BookmarkItem.builder(groupId, stack, recipe, BookmarkItemType.RESULT).multiplier(multiplier) .build(), true); } - for (ItemStack stack : ingredients.values()) { + for (ItemStack stack : ingredients) { this.addItem( BookmarkItem.builder(groupId, stack, recipe, BookmarkItemType.INGREDIENT).multiplier(multiplier) .build(),