diff --git a/src/main/java/net/minecraftforge/client/GuiIngameForge.java b/src/main/java/net/minecraftforge/client/GuiIngameForge.java index 10776a714d..b916f28d50 100644 --- a/src/main/java/net/minecraftforge/client/GuiIngameForge.java +++ b/src/main/java/net/minecraftforge/client/GuiIngameForge.java @@ -219,6 +219,7 @@ public class GuiIngameForge extends GuiIngame if (pre(CROSSHAIRS)) return; bind(Gui.ICONS); GlStateManager.enableBlend(); + GlStateManager.enableAlphaTest(); super.renderAttackIndicator(partialTicks); post(CROSSHAIRS); } diff --git a/src/main/java/net/minecraftforge/fml/ModLoader.java b/src/main/java/net/minecraftforge/fml/ModLoader.java index 1c329087b4..43cb565c6c 100644 --- a/src/main/java/net/minecraftforge/fml/ModLoader.java +++ b/src/main/java/net/minecraftforge/fml/ModLoader.java @@ -159,6 +159,11 @@ public class ModLoader return modFile.getScanResult().getTargets().entrySet().stream(). map(e-> { try { + IModInfo info = modInfoMap.get(e.getKey()); + if (info == null) { + loadingExceptions.add(new ModLoadingException(null, ModLoadingStage.CONSTRUCT, "fml.modloading.missingmetadata", null, e.getKey())); + return null; + } return e.getValue().loadMod(modInfoMap.get(e.getKey()), modClassLoader, modFile.getScanResult()); } catch (ModLoadingException mle) { loadingExceptions.add(mle); diff --git a/src/main/resources/assets/forge/lang/en_us.json b/src/main/resources/assets/forge/lang/en_us.json index cba3d1db71..901a018dfc 100644 --- a/src/main/resources/assets/forge/lang/en_us.json +++ b/src/main/resources/assets/forge/lang/en_us.json @@ -20,6 +20,7 @@ "fml.button.open.mods.folder": "Open Mods Folder", "fml.loadingerrorscreen.header": "Error loading mods\n{0,choice,1#1 error has|1<{0} errors have} occurred during loading", "fml.language.missingversion": "Mod File {5} needs language provider {3}:{4,vr} to load\n\u00a77We have found {6,i18n,fml.messages.artifactversion}", + "fml.modloading.missingmetadata": "mods.toml missing metadata for modid {0}", "fml.modloading.failedtoloadmodclass":"{0,modinfo,name} has class loading errors\n\u00a77{2,exc,msg}", "fml.modloading.failedtoloadmod":"{0,modinfo,name} ({0,modinfo,id}) has failed to load correctly\n\u00a77{2,exc,msg}", "fml.modloading.errorduringevent":"{0,modinfo,name} ({0,modinfo,id}) encountered an error during the {1,lower} event phase\n\u00a77{2,exc,msg}", diff --git a/src/main/resources/log4j2.xml b/src/main/resources/log4j2.xml index 2e43a73d54..2e31bee86a 100644 --- a/src/main/resources/log4j2.xml +++ b/src/main/resources/log4j2.xml @@ -3,10 +3,10 @@ - + - - + + diff --git a/src/main/resources/log4j2_server.xml b/src/main/resources/log4j2_server.xml index 239b2a41d1..607f9e7f45 100644 --- a/src/main/resources/log4j2_server.xml +++ b/src/main/resources/log4j2_server.xml @@ -3,10 +3,10 @@ - + - - + +