From 4b3799f460b851866b3439c7eea9fc622ebd9340 Mon Sep 17 00:00:00 2001 From: Ben Staddon Date: Thu, 9 Nov 2017 22:31:39 +0000 Subject: [PATCH] Change item model alpha tests to match values used for rendering (#4490) --- .../java/net/minecraftforge/client/model/ItemLayerModel.java | 2 +- .../minecraftforge/client/model/ItemTextureQuadConverter.java | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/main/java/net/minecraftforge/client/model/ItemLayerModel.java b/src/main/java/net/minecraftforge/client/model/ItemLayerModel.java index a0617fbe89..6520fdbd2e 100644 --- a/src/main/java/net/minecraftforge/client/model/ItemLayerModel.java +++ b/src/main/java/net/minecraftforge/client/model/ItemLayerModel.java @@ -142,7 +142,7 @@ public final class ItemLayerModel implements IModel for(int u = 0; u < uMax; u++) { int alpha = getAlpha(pixels, uMax, vMax, u, v); - boolean t = alpha == 0; + boolean t = alpha / 255f <= 0.1f; if (!t && alpha < 255) { diff --git a/src/main/java/net/minecraftforge/client/model/ItemTextureQuadConverter.java b/src/main/java/net/minecraftforge/client/model/ItemTextureQuadConverter.java index 9a22abb233..456904931f 100644 --- a/src/main/java/net/minecraftforge/client/model/ItemTextureQuadConverter.java +++ b/src/main/java/net/minecraftforge/client/model/ItemTextureQuadConverter.java @@ -206,10 +206,9 @@ public final class ItemTextureQuadConverter return quads; } - // true if alpha != 0 private static boolean isVisible(int color) { - return (color >> 24 & 255) > 0; + return (color >> 24 & 255) / 255f > 0.1f; } /**