From 19bbb88e52504a4d82d4f7323143b81a2b78ad3a Mon Sep 17 00:00:00 2001 From: Paint_Ninja Date: Sun, 24 Sep 2023 17:56:35 +0100 Subject: [PATCH] Optimise `ForgeRegistry#validateContent` by removing optimization that ModLauncher broke. (#9715) --- .../minecraftforge/registries/ForgeRegistry.java | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/src/main/java/net/minecraftforge/registries/ForgeRegistry.java b/src/main/java/net/minecraftforge/registries/ForgeRegistry.java index 121229e9d9..7a3548b6a6 100644 --- a/src/main/java/net/minecraftforge/registries/ForgeRegistry.java +++ b/src/main/java/net/minecraftforge/registries/ForgeRegistry.java @@ -19,7 +19,6 @@ import net.minecraft.tags.TagKey; import net.minecraft.world.level.biome.Biome; import net.minecraftforge.common.util.LogMessageAdapter; import net.minecraftforge.fml.ModLoadingContext; -import net.minecraftforge.fml.util.ObfuscationReflectionHelper; import net.minecraftforge.registries.tags.ITagManager; import org.apache.commons.lang3.Validate; @@ -54,8 +53,8 @@ import org.jetbrains.annotations.VisibleForTesting; public class ForgeRegistry implements IForgeRegistryInternal, IForgeRegistryModifiable { public static Marker REGISTRIES = MarkerManager.getMarker("REGISTRIES"); - private static Marker REGISTRYDUMP = MarkerManager.getMarker("REGISTRYDUMP"); - private static Logger LOGGER = LogManager.getLogger(); + private static final Marker REGISTRYDUMP = MarkerManager.getMarker("REGISTRYDUMP"); + private static final Logger LOGGER = LogManager.getLogger(); private final RegistryManager stage; private final BiMap ids = HashBiMap.create(); private final BiMap names = HashBiMap.create(); @@ -571,15 +570,6 @@ public class ForgeRegistry implements IForgeRegistryInternal, IForgeRegist void validateContent(ResourceLocation registryName) { - try - { - ObfuscationReflectionHelper.findMethod(BitSet.class, "trimToSize").invoke(this.availabilityMap); - } - catch (Exception e) - { - //We don't care... Just a micro-optimization - } - for (V obj : this) { int id = getID(obj);