upstream/EndlessIDs
2
0 Fork 0
mirror of https://github.com/GTMEGA/EndlessIDs.git synced 2026-11-12 03:47:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

put explanation in javadoc

Browse Source
This commit is contained in:
FalsePattern committed 2022-07-18 21:49:58 +02:00
1 parent e44229300a
commit 34a8ff7833
1 file changed
+51 -52
Download Patch File Download Diff File Expand all files Collapse all files
src/main/java/com/falsepattern/endlessids/asm/transformer/ChunkProviderSuperPatcher.java
+51 -52
View File
@@ -25,10 +25,57 @@ import java.util.function.BiFunction;
import java.util.function.Function;
/**
* This class is the bread and butter of the patching logic from now on. It covers about 90% of cases where manual patching
* was required, and so with a heavy heart, I (finally) implemented a universal patch.
* <p>This class is the bread and butter of the patching logic from now on. It covers about 90% of cases where manual patching
* was required, and so with a heavy heart, I (finally) implemented a universal patch.</p>
*
* See the end of the file for the 2 possibilities that this transformer handles.
* <pre>
* Java form:
* ...
* byte[] abyte = chunk.getBiomeArray(); //replace byte[] with short[] and getBiomeArray with getBiomeShortArray
*
* for (int k = 0; k < abyte.length; ++k) {
* //Possibility A:
* abyte[k] = (byte)abiomegenbase[k].biomeID; //from local variable //replace byte cast with short cast
*
* //Possibility B:
* abyte[k] = (byte)this.biomesToGenerate[k].biomeID; //from arbitrary field //replace byte cast with short cast
* }
* ...
* In ASM form:
*
* L1
* ALOAD chunk
* INVOKEVIRTUAL net/minecraft/world/chunk/Chunk.getBiomeArray ()[B //Replace with INVOKEVIRTUAL net/minecraft/world/chunk/Chunk.getBiomeShortArray ()[S
* ASTORE abyte
* L2
* ICONST_0
* ISTORE k
* L3
* FRAME <snip>
* ILOAD k
* ALOAD abyte
* ARRAYLENGTH
* IF_ICMPGE L6
* L4
* ALOAD abyte
* ILOAD k
*
* //Possibility A:
* ALOAD abiomegenbase
* //Possibility B:
* ALOAD <something else, usually 0, so only check for 0>
* GETFIELD classname.fieldname : [Lnet/minecraft/world/biome/BiomeGenBase;
*
* ILOAD k
* AALOAD
* GETFIELD net/minecraft/world/biome/BiomeGenBase.biomeID : I
* I2B //Replace with I2S
* BASTORE //Replace with SASTORE
* L5
* IINC k 1
* GOTO L3
* L6
* </pre>
*/
public class ChunkProviderSuperPatcher implements IClassNodeTransformer {
private static final String BIOME_GEN_BASE_CLASS = "net/minecraft/world/biome/BiomeGenBase";
@@ -274,52 +321,4 @@ public class ChunkProviderSuperPatcher implements IClassNodeTransformer {
final List<Object> locals = new ArrayList<>();
}
}
/*
Java form:
...
byte[] abyte = chunk.getBiomeArray(); //replace byte[] with short[] and getBiomeArray with getBiomeShortArray
for (int k = 0; k < abyte.length; ++k) {
//Possibility A:
abyte[k] = (byte)abiomegenbase[k].biomeID; //from local variable //replace byte cast with short cast
//Possibility B:
abyte[k] = (byte)this.biomesToGenerate[k].biomeID; //from arbitrary field //replace byte cast with short cast
}
...
In ASM form:
L1
ALOAD chunk
INVOKEVIRTUAL net/minecraft/world/chunk/Chunk.getBiomeArray ()[B //Replace with INVOKEVIRTUAL net/minecraft/world/chunk/Chunk.getBiomeShortArray ()[S
ASTORE abyte
L2
ICONST_0
ISTORE k
L3
FRAME <snip>
ILOAD k
ALOAD abyte
ARRAYLENGTH
IF_ICMPGE L6
L4
ALOAD abyte
ILOAD k
//Possibility A:
ALOAD abiomegenbase
//Possibility B:
ALOAD <something else, usually 0, so only check for 0>
GETFIELD classname.fieldname : [Lnet/minecraft/world/biome/BiomeGenBase;
ILOAD k
AALOAD
GETFIELD net/minecraft/world/biome/BiomeGenBase.biomeID : I
I2B //Replace with I2S
BASTORE //Replace with SASTORE
L5
IINC k 1
GOTO L3
L6
*/
}