From bf858a7a1af80f08e77b06e22fbb9bf72183b82d Mon Sep 17 00:00:00 2001 From: bigguy345 Date: Sun, 4 Jan 2026 01:27:14 +0200 Subject: [PATCH] Removed AutoComplete list limit --- .../util/script/autocomplete/AutocompleteManager.java | 10 ++++++++++ .../script/autocomplete/JavaAutocompleteProvider.java | 5 ----- 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/src/main/java/noppes/npcs/client/gui/util/script/autocomplete/AutocompleteManager.java b/src/main/java/noppes/npcs/client/gui/util/script/autocomplete/AutocompleteManager.java index 6eea5a9f5..bc725806f 100644 --- a/src/main/java/noppes/npcs/client/gui/util/script/autocomplete/AutocompleteManager.java +++ b/src/main/java/noppes/npcs/client/gui/util/script/autocomplete/AutocompleteManager.java @@ -25,6 +25,9 @@ public class AutocompleteManager { /** Minimum characters before showing suggestions (for non-dot triggers) */ private static final int MIN_PREFIX_LENGTH = 1; + + /** Maximum number of suggestions to show (performance/UX) */ + private static final int MAX_SUGGESTIONS = 150; /** Pattern for identifier characters */ private static final Pattern IDENTIFIER_PATTERN = Pattern.compile("[a-zA-Z_$][a-zA-Z0-9_$]*"); @@ -356,6 +359,13 @@ public class AutocompleteManager { // Get suggestions from appropriate provider AutocompleteProvider provider = document.isJavaScript() ? jsProvider : javaProvider; List suggestions = provider.getSuggestions(context); + + // Limit suggestions to prevent overwhelming the UI and improve performance + // Items are already sorted by relevance in the provider + if (suggestions.size() > MAX_SUGGESTIONS) { + // Disabled for now to show all suggestions + // suggestions = suggestions.subList(0, MAX_SUGGESTIONS); + } // Show menu if (suggestions.isEmpty()) { diff --git a/src/main/java/noppes/npcs/client/gui/util/script/autocomplete/JavaAutocompleteProvider.java b/src/main/java/noppes/npcs/client/gui/util/script/autocomplete/JavaAutocompleteProvider.java index 90dd15b53..d3b64d877 100644 --- a/src/main/java/noppes/npcs/client/gui/util/script/autocomplete/JavaAutocompleteProvider.java +++ b/src/main/java/noppes/npcs/client/gui/util/script/autocomplete/JavaAutocompleteProvider.java @@ -51,11 +51,6 @@ public class JavaAutocompleteProvider implements AutocompleteProvider { // Sort by score Collections.sort(items); - // Limit results - if (items.size() > 50) { - items = items.subList(0, 50); - } - return items; }