From bacbc877bd5942393a9e6f2f7f9e043c223cd8c7 Mon Sep 17 00:00:00 2001 From: bigguy345 Date: Sat, 27 Dec 2025 18:54:56 +0200 Subject: [PATCH] Made AssignmentInfo LHS start from statementStart, modifiers and type inclusive --- .../client/gui/util/script/interpreter/AssignmentInfo.java | 4 ++-- .../gui/util/script/interpreter/hover/TokenHoverInfo.java | 7 ++----- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/src/main/java/noppes/npcs/client/gui/util/script/interpreter/AssignmentInfo.java b/src/main/java/noppes/npcs/client/gui/util/script/interpreter/AssignmentInfo.java index 753adb86e..dd7c15f44 100644 --- a/src/main/java/noppes/npcs/client/gui/util/script/interpreter/AssignmentInfo.java +++ b/src/main/java/noppes/npcs/client/gui/util/script/interpreter/AssignmentInfo.java @@ -238,7 +238,7 @@ public class AssignmentInfo { * Check if the given global position falls within the LHS (target) of this assignment. */ public boolean containsLhsPosition(int position) { - return position >= lhsStart && position < lhsEnd; + return position >= statementStart && position < lhsEnd; } /** @@ -252,7 +252,7 @@ public class AssignmentInfo { * Check if the given global position falls anywhere in this assignment (LHS or RHS). */ public boolean containsPosition(int position) { - return position >= lhsStart && position <= rhsEnd; + return position >= statementStart && position <= rhsEnd; } // ==================== ERROR TYPE CHECKS ==================== diff --git a/src/main/java/noppes/npcs/client/gui/util/script/interpreter/hover/TokenHoverInfo.java b/src/main/java/noppes/npcs/client/gui/util/script/interpreter/hover/TokenHoverInfo.java index a55386641..dc275cfaf 100644 --- a/src/main/java/noppes/npcs/client/gui/util/script/interpreter/hover/TokenHoverInfo.java +++ b/src/main/java/noppes/npcs/client/gui/util/script/interpreter/hover/TokenHoverInfo.java @@ -127,16 +127,13 @@ public class TokenHoverInfo { break; case LITERAL: - if (info.hasErrors()) - return info; - return null; case KEYWORD: case MODIFIER: case STRING: case COMMENT: - // These don't need hover info typically + if (info.hasErrors()) + return info; return null; - default: // For other types, try to extract any available metadata if (token.getTypeInfo() != null) {