From ac223cbb53145fbedcd80200534ff59de28522df Mon Sep 17 00:00:00 2001
From: bigguy345 <monkeybar3200@gmail.com>
Date: Fri, 13 Feb 2026 04:06:59 +0200
Subject: [PATCH] IAction exceptions now report to script console

---
 .../npcs/controllers/data/action/Action.java       | 14 ++++++++++++++
 .../data/action/action/ConditionalAction.java      |  9 +++++++++
 2 files changed, 23 insertions(+)

diff --git a/src/main/java/noppes/npcs/controllers/data/action/Action.java b/src/main/java/noppes/npcs/controllers/data/action/Action.java
index b7bce1102..cb2af9454 100644
--- a/src/main/java/noppes/npcs/controllers/data/action/Action.java
+++ b/src/main/java/noppes/npcs/controllers/data/action/Action.java
@@ -6,6 +6,7 @@ import noppes.npcs.api.handler.data.IActionQueue;
 import noppes.npcs.api.handler.data.actions.IConditionalAction;
 import noppes.npcs.controllers.ScriptContainer;
 import noppes.npcs.scripted.CustomNPCsException;
+import org.apache.commons.lang3.exception.ExceptionUtils;
 
 import java.util.HashMap;
 import java.util.Map;
@@ -344,6 +345,10 @@ public class Action implements IAction {
         try {
             onStart.accept(this);
         } catch (Throwable t) {
+            String err = "IAction"  + getName() + "  onStart threw an exception:";
+            if (reportTo != null)
+                reportTo.appendConsole(err + "\n" + ExceptionUtils.getStackTrace(t));
+            
             manager.LOGGER.error("onStart Task of " + this + " threw an exception:", t);
         }
 
@@ -359,6 +364,11 @@ public class Action implements IAction {
             task.accept(this);
             count++;
         } catch (Throwable t) {
+            String err = "IAction '" + name + "' threw an exception:";
+
+            if (reportTo != null)
+                reportTo.appendConsole(err + "\n" + ExceptionUtils.getStackTrace(t));
+
             manager.LOGGER.error("Task of " + this + " threw an exception:", t);
             markDone();
         }
@@ -374,6 +384,10 @@ public class Action implements IAction {
         try {
             onDone.accept(this);
         } catch (Throwable t) {
+            String err = "IAction"  + getName() + "  onDone threw an exception:";
+            if (reportTo != null)
+                reportTo.appendConsole(err + "\n" + ExceptionUtils.getStackTrace(t));
+
             manager.LOGGER.error("onDone Task of " + this + " threw an exception:", t);
         }
 
diff --git a/src/main/java/noppes/npcs/controllers/data/action/action/ConditionalAction.java b/src/main/java/noppes/npcs/controllers/data/action/action/ConditionalAction.java
index 9e608df37..427749e33 100644
--- a/src/main/java/noppes/npcs/controllers/data/action/action/ConditionalAction.java
+++ b/src/main/java/noppes/npcs/controllers/data/action/action/ConditionalAction.java
@@ -4,6 +4,7 @@ import noppes.npcs.api.handler.data.IAction;
 import noppes.npcs.api.handler.data.actions.IConditionalAction;
 import noppes.npcs.controllers.data.action.Action;
 import noppes.npcs.controllers.data.action.ActionManager;
+import org.apache.commons.lang3.exception.ExceptionUtils;
 
 import java.util.function.Consumer;
 import java.util.function.Function;
@@ -130,6 +131,10 @@ public class ConditionalAction extends Action implements IConditionalAction {
             count++;
             taskExecuted = true;
         } catch (Throwable t) {
+            String err = "IConditionalAction '" + getName() + "' threw an exception:";
+            if (reportTo != null)
+                reportTo.appendConsole(err + "\n" + ExceptionUtils.getStackTrace(t));
+            
             manager.LOGGER.error("Task of " + this + " threw an exception:", t);
             markDone();
         }
@@ -146,6 +151,10 @@ public class ConditionalAction extends Action implements IConditionalAction {
         try {
             onTermination.accept(this);
         } catch (Throwable t) {
+            String err = "IConditionalAction"  + getName() + "  onTermination threw an exception:";
+            if (reportTo != null)
+                reportTo.appendConsole(err + "\n" + ExceptionUtils.getStackTrace(t));
+
             manager.LOGGER.error("Termination Task of " + this + " threw an exception:", t);
         }