From a028142dda9e2e362e1a144e126b0bab44e4fb43 Mon Sep 17 00:00:00 2001
From: KAMKEEL <28842281+KAMKEEL@users.noreply.github.com>
Date: Tue, 11 Aug 2026 05:08:15 -0400
Subject: [PATCH] Fix mouse wheel scrolling in the script editors

Mouse.getDWheel() clears the accumulated delta, so whichever widget polled it
first in a frame took it and every later reader saw zero. The script text areas
polled it themselves, after the parent screen had already drained it for its
scroll lists, so the wheel did nothing in the player, NPC and event script GUIs.
The screen now reads the wheel once per frame into the mouseScroll field it
already declared for this, and each widget zeroes it when it consumes it.
---
 .../npcs/client/gui/util/GuiNPCInterface.java   | 17 +++++++++++++++--
 .../npcs/client/gui/util/GuiScriptTextArea.java |  6 ++++--
 .../client/gui/util/GuiScriptTextArea1.java     |  6 ++++--
 3 files changed, 23 insertions(+), 6 deletions(-)

diff --git a/src/main/java/noppes/npcs/client/gui/util/GuiNPCInterface.java b/src/main/java/noppes/npcs/client/gui/util/GuiNPCInterface.java
index 08a5dff00..24d08cff2 100644
--- a/src/main/java/noppes/npcs/client/gui/util/GuiNPCInterface.java
+++ b/src/main/java/noppes/npcs/client/gui/util/GuiNPCInterface.java
@@ -515,15 +515,28 @@ public abstract class GuiNPCInterface extends GuiScreen {
         }
 
         boolean subGui = hasSubGui();
+
+        // Mouse.getDWheel() clears the accumulated delta, so only the first caller in a frame
+        // ever sees it. Read it once here and let each widget take it in turn; anything that
+        // consumes it zeroes it so later widgets - the script editor, for one - are not left
+        // reading an already-drained wheel.
+        mouseScroll = Mouse.getDWheel();
+
         drawCenteredString(fontRendererObj, title, width / 2, guiTop + 4, 0xffffff);
         for (GuiNpcLabel label : labels.values())
             label.drawLabel(this, fontRendererObj);
         for (GuiCustomScroll scroll : scrolls.values()) {
             scroll.updateSubGUI(subGui);
-            scroll.drawScreen(drawX, drawY, f, !subGui && scroll.isMouseOver(drawX, drawY) ? Mouse.getDWheel() : 0);
+            int delta = !subGui && scroll.isMouseOver(drawX, drawY) ? mouseScroll : 0;
+            if (delta != 0)
+                mouseScroll = 0;
+            scroll.drawScreen(drawX, drawY, f, delta);
         }
         for (GuiScrollWindow guiScrollableComponent : scrollWindows.values()) {
-            guiScrollableComponent.drawScreen(drawX, drawY, f, !subGui && guiScrollableComponent.isMouseOver(drawX, drawY) ? Mouse.getDWheel() : 0);
+            int delta = !subGui && guiScrollableComponent.isMouseOver(drawX, drawY) ? mouseScroll : 0;
+            if (delta != 0)
+                mouseScroll = 0;
+            guiScrollableComponent.drawScreen(drawX, drawY, f, delta);
         }
         for (GuiDiagram diagram : diagrams.values()) {
             diagram.drawDiagram(drawX, drawY, subGui);
diff --git a/src/main/java/noppes/npcs/client/gui/util/GuiScriptTextArea.java b/src/main/java/noppes/npcs/client/gui/util/GuiScriptTextArea.java
index 647621117..70283b7e0 100644
--- a/src/main/java/noppes/npcs/client/gui/util/GuiScriptTextArea.java
+++ b/src/main/java/noppes/npcs/client/gui/util/GuiScriptTextArea.java
@@ -624,9 +624,11 @@ public class GuiScriptTextArea extends GuiNpcTextField {
         int maxScroll = Math.max(0, getPaddedLineCount() - container.visibleLines);
 
         // Handle mouse wheel scroll
-        int wheelDelta = ((GuiNPCInterface) listener).mouseScroll = Mouse.getDWheel();
+        // Take whatever the parent screen has left for this frame rather than polling the wheel
+        // again - the poll is destructive and the parent has already drained it.
+        int wheelDelta = listener instanceof GuiNPCInterface ? ((GuiNPCInterface) listener).mouseScroll : Mouse.getDWheel();
         if (listener instanceof GuiNPCInterface) {
-            ((GuiNPCInterface) listener).mouseScroll = wheelDelta;
+            ((GuiNPCInterface) listener).mouseScroll = 0;
 
             // Intercept wheel scroll for tooltip (highest priority)
             // Only consume the wheel event when the tooltip actually has content to scroll;
diff --git a/src/main/java/noppes/npcs/client/gui/util/GuiScriptTextArea1.java b/src/main/java/noppes/npcs/client/gui/util/GuiScriptTextArea1.java
index 60e5a38a0..a5a555514 100644
--- a/src/main/java/noppes/npcs/client/gui/util/GuiScriptTextArea1.java
+++ b/src/main/java/noppes/npcs/client/gui/util/GuiScriptTextArea1.java
@@ -486,9 +486,11 @@ public class GuiScriptTextArea1 extends GuiNpcTextField {
         int maxScroll = Math.max(0, getPaddedLineCount() - container.visibleLines);
 
         // Handle mouse wheel scroll
-        int wheelDelta = ((GuiNPCInterface) listener).mouseScroll = Mouse.getDWheel();
+        // Take whatever the parent screen has left for this frame rather than polling the wheel
+        // again - the poll is destructive and the parent has already drained it.
+        int wheelDelta = listener instanceof GuiNPCInterface ? ((GuiNPCInterface) listener).mouseScroll : Mouse.getDWheel();
         if (listener instanceof GuiNPCInterface) {
-            ((GuiNPCInterface) listener).mouseScroll = wheelDelta;
+            ((GuiNPCInterface) listener).mouseScroll = 0;
             boolean canScroll = !KEYS_OVERLAY.isVisible() || KEYS_OVERLAY.isVisible() && !KEYS_OVERLAY.aboveOverlay;
             if (wheelDelta != 0 && canScroll) 
                 scroll.applyWheelScroll(wheelDelta, maxScroll);