From 8f36ad7e18781b233805ec3e15b4531708bfd6ae Mon Sep 17 00:00:00 2001 From: Kam Date: Thu, 22 Aug 2024 13:42:12 -0400 Subject: [PATCH 1/2] Add Null Check --- src/main/java/noppes/npcs/client/ClientTickHandler.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/main/java/noppes/npcs/client/ClientTickHandler.java b/src/main/java/noppes/npcs/client/ClientTickHandler.java index e9f3f3b57..6424ea4ad 100644 --- a/src/main/java/noppes/npcs/client/ClientTickHandler.java +++ b/src/main/java/noppes/npcs/client/ClientTickHandler.java @@ -63,8 +63,9 @@ public class ClientTickHandler{ } else if (MusicController.Instance.isPlaying() && MusicController.Instance.getEntity() != null) { Entity entity = MusicController.Instance.getEntity(); if (MusicController.Instance.getOffRange() > 0 && - (Minecraft.getMinecraft().thePlayer.getDistanceToEntity(entity) > MusicController.Instance.getOffRange() - || entity.dimension != Minecraft.getMinecraft().thePlayer.dimension)) { + (Minecraft.getMinecraft().thePlayer == null || + Minecraft.getMinecraft().thePlayer.getDistanceToEntity(entity) > MusicController.Instance.getOffRange() || + entity.dimension != Minecraft.getMinecraft().thePlayer.dimension)) { MusicController.Instance.stopMusic(); } } From 6606493efeb78c5dc78fb730ed6051c8700bd845 Mon Sep 17 00:00:00 2001 From: Kam Date: Thu, 22 Aug 2024 13:43:37 -0400 Subject: [PATCH 2/2] Close on Esc Sub Gui Issues for Animations --- .../java/noppes/npcs/client/gui/SubGuiAnimationFrame.java | 5 +++-- .../java/noppes/npcs/client/gui/SubGuiAnimationOptions.java | 1 + 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/main/java/noppes/npcs/client/gui/SubGuiAnimationFrame.java b/src/main/java/noppes/npcs/client/gui/SubGuiAnimationFrame.java index f719b649b..89254ce2d 100644 --- a/src/main/java/noppes/npcs/client/gui/SubGuiAnimationFrame.java +++ b/src/main/java/noppes/npcs/client/gui/SubGuiAnimationFrame.java @@ -6,12 +6,13 @@ import noppes.npcs.controllers.data.Frame; public class SubGuiAnimationFrame extends SubGuiInterface implements ITextfieldListener { private final Frame editingFrame; - + public SubGuiAnimationFrame(Frame editingFrame) { this.editingFrame = editingFrame; setBackground("smallbg.png"); + this.closeOnEsc = true; } - + @Override public void initGui() { super.initGui(); diff --git a/src/main/java/noppes/npcs/client/gui/SubGuiAnimationOptions.java b/src/main/java/noppes/npcs/client/gui/SubGuiAnimationOptions.java index 4a0724644..5a021a406 100644 --- a/src/main/java/noppes/npcs/client/gui/SubGuiAnimationOptions.java +++ b/src/main/java/noppes/npcs/client/gui/SubGuiAnimationOptions.java @@ -12,6 +12,7 @@ public class SubGuiAnimationOptions extends SubGuiInterface { public SubGuiAnimationOptions(Animation animation) { this.animation = animation; setBackground("smallbg.png"); + this.closeOnEsc = true; } @Override