fix waila body flickering when looking at a certus quartz tank (#350)

src/main/java/com/glodblock/github/crossmod/waila/CertusQuartzTankWailaDataProvider.java

@@ -0,0 +1,30 @@
+package com.glodblock.github.crossmod.waila;
+
+import java.util.List;
+
+import net.minecraft.item.ItemStack;
+import net.minecraft.tileentity.TileEntity;
+import net.minecraftforge.fluids.FluidTankInfo;
+
+import com.glodblock.github.common.tile.TileCertusQuartzTank;
+
+import appeng.integration.modules.waila.BaseWailaDataProvider;
+import mcp.mobius.waila.api.IWailaConfigHandler;
+import mcp.mobius.waila.api.IWailaDataAccessor;
+
+public class CertusQuartzTankWailaDataProvider extends BaseWailaDataProvider {
+
+    @Override
+    public List<String> getWailaBody(final ItemStack itemStack, final List<String> currentToolTip,
+            final IWailaDataAccessor accessor, final IWailaConfigHandler config) {
+        TileEntity tileEntity = accessor.getTileEntity();
+        if (tileEntity instanceof TileCertusQuartzTank quartzTank) {
+            FluidTankInfo info = quartzTank.getTankInfo(true)[0];
+            if (info.fluid != null) {
+                currentToolTip
+                        .add(Tooltip.fluidFormat(info.fluid.getLocalizedName(), info.fluid.amount, info.capacity));
+            }
+        }
+        return currentToolTip;
+    }
+}

src/main/java/com/glodblock/github/crossmod/waila/VanillaTileWailaDataProvider.java

@@ -1,71 +0,0 @@
-package com.glodblock.github.crossmod.waila;
-
-import java.util.List;
-
-import net.minecraft.entity.player.EntityPlayerMP;
-import net.minecraft.item.ItemStack;
-import net.minecraft.nbt.NBTTagCompound;
-import net.minecraft.tileentity.TileEntity;
-import net.minecraft.world.World;
-
-import com.glodblock.github.crossmod.waila.vanilla.FluidInvWailaDataProvider;
-import com.google.common.collect.Lists;
-
-import mcp.mobius.waila.api.IWailaConfigHandler;
-import mcp.mobius.waila.api.IWailaDataAccessor;
-import mcp.mobius.waila.api.IWailaDataProvider;
-
-public class VanillaTileWailaDataProvider implements IWailaDataProvider {
-
-    private final List<IWailaDataProvider> providers;
-
-    public VanillaTileWailaDataProvider() {
-        final IWailaDataProvider fluidInv = new FluidInvWailaDataProvider();
-        this.providers = Lists.newArrayList(fluidInv);
-    }
-
-    @Override
-    public ItemStack getWailaStack(final IWailaDataAccessor accessor, final IWailaConfigHandler config) {
-        return null;
-    }
-
-    @Override
-    public List<String> getWailaHead(final ItemStack itemStack, final List<String> currentToolTip,
-            final IWailaDataAccessor accessor, final IWailaConfigHandler config) {
-        for (final IWailaDataProvider provider : this.providers) {
-            provider.getWailaHead(itemStack, currentToolTip, accessor, config);
-        }
-
-        return currentToolTip;
-    }
-
-    @Override
-    public List<String> getWailaBody(final ItemStack itemStack, final List<String> currentToolTip,
-            final IWailaDataAccessor accessor, final IWailaConfigHandler config) {
-        for (final IWailaDataProvider provider : this.providers) {
-            provider.getWailaBody(itemStack, currentToolTip, accessor, config);
-        }
-
-        return currentToolTip;
-    }
-
-    @Override
-    public List<String> getWailaTail(final ItemStack itemStack, final List<String> currentToolTip,
-            final IWailaDataAccessor accessor, final IWailaConfigHandler config) {
-        for (final IWailaDataProvider provider : this.providers) {
-            provider.getWailaTail(itemStack, currentToolTip, accessor, config);
-        }
-
-        return currentToolTip;
-    }
-
-    @Override
-    public NBTTagCompound getNBTData(final EntityPlayerMP player, final TileEntity te, final NBTTagCompound tag,
-            final World world, final int x, final int y, final int z) {
-        for (final IWailaDataProvider provider : this.providers) {
-            provider.getNBTData(player, te, tag, world, x, y, z);
-        }
-
-        return tag;
-    }
-}

src/main/java/com/glodblock/github/crossmod/waila/WailaInit.java

@@ -1,6 +1,6 @@
 package com.glodblock.github.crossmod.waila;
 
-import net.minecraft.tileentity.TileEntity;
+import com.glodblock.github.common.tile.TileCertusQuartzTank;
 
 import appeng.api.parts.IPartHost;
 import appeng.tile.AEBaseTile;
@@ -26,9 +26,8 @@ public class WailaInit {
         registrar.registerBodyProvider(tile, AEBaseTile.class);
         registrar.registerNBTProvider(tile, AEBaseTile.class);
 
-        final IWailaDataProvider vanillaTile = new VanillaTileWailaDataProvider();
-        registrar.registerBodyProvider(vanillaTile, TileEntity.class);
-        registrar.registerNBTProvider(vanillaTile, TileEntity.class);
+        final IWailaDataProvider certusQuartzTank = new CertusQuartzTankWailaDataProvider();
+        registrar.registerBodyProvider(certusQuartzTank, TileCertusQuartzTank.class);
 
     }
 }

src/main/java/com/glodblock/github/crossmod/waila/vanilla/FluidInvWailaDataProvider.java

@@ -1,50 +0,0 @@
-package com.glodblock.github.crossmod.waila.vanilla;
-
-import java.util.List;
-
-import net.minecraft.entity.player.EntityPlayerMP;
-import net.minecraft.item.ItemStack;
-import net.minecraft.nbt.NBTTagCompound;
-import net.minecraft.tileentity.TileEntity;
-import net.minecraft.world.World;
-import net.minecraftforge.fluids.FluidTankInfo;
-
-import com.glodblock.github.common.tile.TileCertusQuartzTank;
-import com.glodblock.github.crossmod.waila.Tooltip;
-import com.glodblock.github.util.Util;
-
-import appeng.integration.modules.waila.BaseWailaDataProvider;
-import mcp.mobius.waila.api.IWailaConfigHandler;
-import mcp.mobius.waila.api.IWailaDataAccessor;
-
-public class FluidInvWailaDataProvider extends BaseWailaDataProvider {
-
-    @Override
-    public List<String> getWailaBody(final ItemStack itemStack, final List<String> currentToolTip,
-            final IWailaDataAccessor accessor, final IWailaConfigHandler config) {
-        final TileEntity te = accessor.getTileEntity();
-        if (te instanceof TileCertusQuartzTank) {
-            if (accessor.getNBTData().hasKey("fluidInv")) {
-                NBTTagCompound data = (NBTTagCompound) accessor.getNBTData().getTag("fluidInv");
-                for (FluidTankInfo info : Util.FluidUtil.fluidTankInfoReadFromNBT(data)) {
-                    if (info.fluid == null) continue;
-                    currentToolTip
-                            .add(Tooltip.fluidFormat(info.fluid.getLocalizedName(), info.fluid.amount, info.capacity));
-                }
-            }
-        }
-        return currentToolTip;
-    }
-
-    @Override
-    public NBTTagCompound getNBTData(final EntityPlayerMP player, final TileEntity te, final NBTTagCompound tag,
-            final World world, final int x, final int y, final int z) {
-        if (te instanceof TileCertusQuartzTank) {
-            NBTTagCompound data = new NBTTagCompound();
-            Util.FluidUtil.fluidTankInfoWriteToNBT(((TileCertusQuartzTank) te).getInternalFluid(), data);
-            tag.setTag("fluidInv", data);
-            te.writeToNBT(tag);
-        }
-        return tag;
-    }
-}

src/main/java/com/glodblock/github/util/Util.java

@@ -7,8 +7,6 @@ import static com.glodblock.github.util.Util.DimensionalCoordSide.hasEnergyCard;
 import static net.minecraft.init.Items.glass_bottle;
 
 import java.io.IOException;
-import java.util.ArrayList;
-import java.util.List;
 import java.util.Map;
 
 import net.minecraft.entity.player.EntityPlayer;
@@ -24,7 +22,6 @@ import net.minecraftforge.fluids.Fluid;
 import net.minecraftforge.fluids.FluidContainerRegistry;
 import net.minecraftforge.fluids.FluidRegistry;
 import net.minecraftforge.fluids.FluidStack;
-import net.minecraftforge.fluids.FluidTankInfo;
 import net.minecraftforge.fluids.IFluidContainerItem;
 
 import org.apache.commons.lang3.tuple.ImmutablePair;
@@ -510,36 +507,6 @@ public final class Util {
 
         public static final ItemStack water_bucket = new ItemStack(Items.water_bucket, 1);
 
-        public static void fluidTankInfoWriteToNBT(FluidTankInfo[] infos, NBTTagCompound data) {
-            int i = 0;
-            for (FluidTankInfo info : infos) {
-                if (info.fluid != null && info.fluid.amount > 0) {
-                    NBTTagCompound fs = new NBTTagCompound();
-                    info.fluid.writeToNBT(fs);
-                    fs.setInteger("capacity", info.capacity);
-                    data.setTag("#" + i, fs);
-                }
-                i++;
-            }
-            data.setInteger("fluidInvSize", i);
-        }
-
-        public static FluidTankInfo[] fluidTankInfoReadFromNBT(NBTTagCompound data) {
-            int i = 0;
-            List<FluidTankInfo> infos = new ArrayList<>();
-            while (data.hasKey("fluidInvSize") && i < data.getInteger("fluidInvSize")) {
-                if (data.hasKey("#" + i)) {
-                    NBTTagCompound tag = (NBTTagCompound) data.getTag("#" + i);
-                    FluidStack fs = FluidStack.loadFluidStackFromNBT(tag);
-                    infos.add(new FluidTankInfo(fs, tag.getInteger("capacity")));
-                } else {
-                    infos.add(new FluidTankInfo(null, 0));
-                }
-                i++;
-            }
-            return infos.toArray(new FluidTankInfo[0]);
-        }
-
         public static IAEFluidStack createAEFluidStack(Fluid fluid) {
             return createAEFluidStack(new FluidStack(fluid, FluidContainerRegistry.BUCKET_VOLUME));
         }